Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav items of fixed "type" retain ability to enter a custom URL. #34224

Closed
getdave opened this issue Aug 23, 2021 · 2 comments
Closed

Nav items of fixed "type" retain ability to enter a custom URL. #34224

getdave opened this issue Aug 23, 2021 · 2 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block

Comments

@getdave
Copy link
Contributor

getdave commented Aug 23, 2021

What problem does this address?

On the current screen if I add a "Page" item it remains as a "Page" item which is always locked to the URL represented by that Page entity. In the new editor the UI affords the ability to edit the URL to be anything. Therefore I can create an item with a specific type, but then update the URL to be something else entirely. This becomes very confusing.

What is your proposed solution?

Consider disabling ability to enter custom URLs when nav item is of a specific type (ie: Page, Post...etc). Alternatively make system "intelligent" enough to convert the nav item to "custom" if/when the user enters a custom URL.

Screenshots

Screen.Capture.on.2021-08-23.at.11-08-49.mov
@getdave getdave added this to Inbox in Navigation editor via automation Aug 23, 2021
@getdave getdave changed the title Nav items of fixed "type" retains ability to enter a custom URL. Nav items of fixed "type" retain ability to enter a custom URL. Aug 23, 2021
@talldan talldan moved this from Inbox to Blocked in Navigation editor Aug 26, 2021
@talldan talldan moved this from Blocked to Needs dev in Navigation editor Aug 26, 2021
@talldan talldan added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block and removed [Block] Navigation Affects the Navigation Block labels Oct 12, 2021
@talldan talldan added this to 📥 To do in Navigation block via automation Oct 12, 2021
@getsource
Copy link
Member

In case it's relevant (I think it is, as far as auto-switching?), during testing of #34072, I noticed that if the link is manually edited to a different post ID that exists, but without using autocomplete, that doesn't update the ID attribute.

@Thelmachido
Copy link

Closing this issue due to the project being moved to an inactive status on the feature projects page in coordination with the project leads. If this work is picked back up, issues can be revisited and reopened as needed.

Thanks for testing this early feature and giving feedback so the wider WordPress project could benefit from the lessons learned!

@Thelmachido Thelmachido closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Navigation editor automation moved this from Needs dev to Done Sep 21, 2022
Navigation block automation moved this from 📥 To do to ✅ Done Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block
Projects
Development

No branches or pull requests

4 participants