Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an hour-and-minute only TimePicker; rename existing TimePicker #34250

Closed
milkcask opened this issue Aug 23, 2021 · 2 comments
Closed

Create an hour-and-minute only TimePicker; rename existing TimePicker #34250

milkcask opened this issue Aug 23, 2021 · 2 comments
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@milkcask
Copy link

milkcask commented Aug 23, 2021

What problem does this address?

The existing TimePicker operates on a full timestamp that points to a specific moment. In many use cases, we expect hour and minute inputs only, and dates could be indefinite or inapplicable.

What is your proposed solution?

We need an hour and minute picker similar to time-picker at baseweb https://baseweb.design/components/time-picker/ .

Additionally, the existing TimePicker should be renamed to DateTimePicker to reflect its actual behaviour and the existing DateTimePicker should either be renamed or merged. However, it would be a breaking change.

proposed label: [Feature] UI Components, Needs Design

@ramonjd ramonjd added [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Aug 26, 2021
@ramonjd
Copy link
Member

ramonjd commented Aug 26, 2021

Thanks for the suggestion @milkcask !

Is it possible to add a couple of screenshots of the current and proposed states, just to help folks, who are looking at this issue for the first time, to understand from a visual perspective.

Also, adding an example use case where you'd expect to have hour and minute inputs only would also help to spark discussion.

Thank you!

@mirka
Copy link
Member

mirka commented Mar 19, 2024

Closing in favor of #52734

@mirka mirka closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants