Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation editor: Menu switcher doesn't show after deleting a menu #34255

Closed
2 tasks done
talldan opened this issue Aug 24, 2021 · 3 comments
Closed
2 tasks done

Navigation editor: Menu switcher doesn't show after deleting a menu #34255

talldan opened this issue Aug 24, 2021 · 3 comments
Labels
[Type] Regression Related to a regression in the latest release

Comments

@talldan
Copy link
Contributor

talldan commented Aug 24, 2021

Description

The change implemented in #29201 seems to have regressed.

Step-by-step reproduction instructions

  1. Visit the navigation editor
  2. Make sure you have at least three menus, if not create some menus
  3. Delete one

Expected: the menu switcher is shown
Actual: another menu is shown

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@talldan talldan added [Feature] Navigation Screen [Type] Regression Related to a regression in the latest release labels Aug 24, 2021
@talldan talldan added this to Inbox in Navigation editor via automation Aug 24, 2021
@Mamaduka
Copy link
Member

Thanks for catching this, @talldan.

I might have introduced this regression with #31320. I will have a look at a possible fix tomorrow.

@javierarce
Copy link
Contributor

👋 Is this issue still relevant?

@Thelmachido
Copy link

Closing this issue due to the project being moved to an inactive status on the feature projects page in coordination with the project leads.

If this work is picked back up, issues can be revisited and reopened as needed. Thanks for testing this early feature and giving feedback so the wider WordPress project could benefit from the lessons learned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

No branches or pull requests

4 participants