Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Block: Adding close button on the link control toggle or allow to close it using Esc key #34307

Closed
2 tasks done
TeBenachi opened this issue Aug 25, 2021 · 1 comment · Fixed by #34314
Closed
2 tasks done

Button Block: Adding close button on the link control toggle or allow to close it using Esc key #34307

TeBenachi opened this issue Aug 25, 2021 · 1 comment · Fixed by #34314
Assignees
@talldan
Labels
[Block] Buttons Affects the Buttons Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Milestone
WordPress 5.8.1

Comments

@TeBenachi
Copy link
Contributor

TeBenachi commented Aug 25, 2021 •
edited

Description

While I was testing for the FSE Program testing, I noticed there was no way to close the Button link toggle using Keyboard.

Step-by-step reproduction instructions

  1. Create a button and enter text link
  2. Open the link control toggle by using Ctrl+K or ⌘+K
  3. Once the toggle opens, search a post or page in the search bar
  4. Select a post or page using down arrow key
  5. Click Tab, and Enter to submit

Once submitted, the link control toggle stays open, and keyboard focus loops within the toggle.

I tried using the Esc key and the arrow keys but could not figure out a way to close the toggle.

Screenshots, screen recording, code snippet

screenshot1

Environment info

No response

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@TeBenachi TeBenachi changed the title Button Block: Adding close button on the link control toggle or allow to close it using Esc key<title> Button Block: Adding close button on the link control toggle or allow to close it using Esc key Aug 25, 2021
@annezazu annezazu added [a11y] Keyboard & Focus [Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended labels Aug 25, 2021
@annezazu
Copy link
Contributor

Great find - thank you for opening!

@talldan talldan added the [Priority] High Used to indicate top priority items that need quick attention label Aug 26, 2021
@talldan talldan added this to the WordPress 5.8.1 milestone Aug 26, 2021
@talldan talldan self-assigned this Aug 26, 2021
@talldan talldan mentioned this issue Aug 26, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 26, 2021
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Buttons Affects the Buttons Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
WordPress 5.8.1
Development

Successfully merging a pull request may close this issue.

Fix button block focus trap after a URL has been added WordPress/gutenberg
4 participants
@talldan @annezazu @priethor @TeBenachi