Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last sibling inserter is redundant #3433

Closed
afercia opened this issue Nov 10, 2017 · 3 comments
Closed

The last sibling inserter is redundant #3433

afercia opened this issue Nov 10, 2017 · 3 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...

Comments

@afercia
Copy link
Contributor

afercia commented Nov 10, 2017

The last sibling inserter is redundant, as it is immediately followed by the bottom inserter. I'd propose to remove it or find a way to not reveal it.

It's redundant visually and also for keyboard users and screen reader users:

  • keyboard users will have to tab through to contiguous controls that do the same thing
  • screen reader users will hear "Insert block" twice when tabbing away from the last block

screen shot 2017-11-10 at 17 34 11

@jorgefilipecosta jorgefilipecosta self-assigned this Nov 13, 2017
@mtias mtias added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Nov 20, 2017
@mtias
Copy link
Member

mtias commented Nov 20, 2017

Also related: #3078

@jasmussen
Copy link
Contributor

I'm very keen on #3078, and I think it'll do a lot for the writing flow.

The key idea of that ticket is that we have the toolbar inserter, we have the slash inserter, and when you make a linebreak between two blocks and insert a block, it gets inserted where your caret is. Point being — although this is a block editor, we are mimicking patterns that are seen in normal textarea editors.

The sibling inserter is an experiment to improve the flow for inserting between blocks, without having to click enter first. I think the idea is sound, even if we need to polish it a bit further. However if we do remove the trailing inserter in #3078 — which I think we should absolutely try sooner rather than later — perhaps we should postpone removing the last sibling inserter, or at least tackle that as part of improvements to that component itself.

@jasmussen
Copy link
Contributor

Closing as the last sibling inserter is no longer present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants