Add support for custom post types in navigation editor

[spacedmonkey]

What problem does this address?

The current menu screen, allows for custom post types to be added to menu. This includes both custom post type posts and archives. See screenshot from current editor.

However these custom post types are not reflected in navigation editor.

What is your proposed solution?

Add support for custom post types in navigation editor

[talldan]

This is supposed to be supported, but it does seem like a bug has crept into the navigation block.

I registered a custom 'Books' post type, and this is what I see in the inserter:

There are two Post Link block variations! I'm pretty sure the second one is supposed to be Books.

[talldan]

Did some more digging, and I've changed my mind, I don't think this is a regression, but just a shortcoming of how the block variation's title is handled:

gutenberg/packages/block-library/src/navigation-link/index.php

Lines 258 to 263 in 44062c5

	if ( property_exists( $entity->labels, 'item_link' ) ) {
	$title = $entity->labels->item_link;
	}
	if ( property_exists( $entity->labels, 'item_link_description' ) ) {
	$description = $entity->labels->item_link_description;
	}

A lot of variations probably won't have an item_link property, but from what I recall the custom post type's labels are merged with the base labels object for a Post, which is why 'Post Link' is shown. I think it should probably fallback to singular_name or name, but it'll be tricky to detect the absence of an item_link.

[spacedmonkey]

@talldan How does this work, if show_in_rest is false but show_in_nav_menus is true? This means that post type can be shown in menus but we can't get the data via the REST API?

Also, is there any way to use the post type's icons as the block icon?

[kathrynwp]

Closing this issue due to the Navigation Screen project being moved to an inactive status on the feature projects page in coordination with the project leads. (The developer documentation in the initial post are no longer accessible)

If this work is picked back up, issues can be revisited and reopened as needed. Thanks for pitching in on this early feature so the wider WordPress project could benefit from the lessons learned!