Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated blockToMenuItem function #35037

Closed
Tracked by #29102
adamziel opened this issue Sep 22, 2021 · 2 comments
Closed
Tracked by #29102

Remove duplicated blockToMenuItem function #35037

adamziel opened this issue Sep 22, 2021 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Package] Block library /packages/block-library

Comments

@adamziel
Copy link
Contributor

adamziel commented Sep 22, 2021

Description

The blockToMenuItem lives in the edit-navigation package, but also in the block-library.

It would be great to remove the duplicate code and have only one copy of that function.

Block library seems to only use it to create a placeholder. Perhaps we could remove it from there? Do the blocks need to know about the underlying data model?

cc @getdave

@getdave
Copy link
Contributor

getdave commented Sep 24, 2021

Yup. That's what I was looking at in #31580.

Do the blocks need to know about the underlying data model?

I don't know the answer to that at the moment. Happy to discuss.

@Mamaduka
Copy link
Member

Closing the issue since the editor is no longer maintained and has been removed from the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Package] Block library /packages/block-library
Projects
None yet
Development

No branches or pull requests

3 participants