Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed block: Undo & redo operations do not work as expected. #35335

Open
jd-alexander opened this issue Oct 5, 2021 · 0 comments
Open

Embed block: Undo & redo operations do not work as expected. #35335

jd-alexander opened this issue Oct 5, 2021 · 0 comments
Labels
[Block] Embed Affects the Embed Block [Feature] History History, undo, redo, revisions, autosave. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
Mobile Apps

Comments

@jd-alexander
Copy link
Contributor

Description

When you add an Embed block and you press undo or redo the behavior is not similar to that of other blocks. The Embed block is not removed when undo is pressed. Instead, the preview flickers. This issue also impacts the mobile component as well.

Step-by-step reproduction instructions

  1. Add an Embed block.
  2. Add an URL.
  3. Wait until the preview loads.
  4. Press undo several times and notice the block flickers and is not removed.

Screenshots, screen recording, code snippet

Click to see video
embed-block-paste-url-undo.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No
@jd-alexander jd-alexander added [Type] Bug An existing feature does not function as intended [Block] Embed Affects the Embed Block labels Oct 5, 2021
@jd-alexander jd-alexander mentioned this issue Oct 5, 2021
Merged
7 tasks
@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 12, 2021
@hypest hypest mentioned this issue Nov 15, 2021
Open
@mchowning mchowning added the [Priority] High Used to indicate top priority items that need quick attention label Nov 16, 2021
@mchowning mchowning added this to Triage in Mobile Apps via automation Nov 16, 2021
@mchowning mchowning moved this from Triage to To do in Mobile Apps Nov 16, 2021
@ellatrix ellatrix added the [Feature] History History, undo, redo, revisions, autosave. label Aug 16, 2023
@SiobhyB SiobhyB removed the [Priority] High Used to indicate top priority items that need quick attention label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Embed Affects the Embed Block [Feature] History History, undo, redo, revisions, autosave. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
Mobile Apps
  
To do
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jd-alexander @SiobhyB @mchowning @ellatrix @fluiddot