New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing a template part does not prompt saving the template #35405
Comments
Hi @carolinan , Done! |
@Denis74F I feel there's still an issue here when following the steps you've provided. If I use replace to select a new template part, I'm making a change to the template and not the template part. However, the save panel indicates changes have been made to both "Page" and "Template Part". Replacing a template part (without making additional changes to it) should be seen as a change to the template, only. |
Hi @chthonic-ds , |
Thank you, I know how to make the template save, but users should not have to do that, it is not at all intuitive and if you are doing many iterations it is too much work. |
I agree. I wanted to help solve the problem. For users it is too difficult, in fact they probably would not succeed. |
I've been testing the Site Editor now for a while as well and it seems very confusing for me, even now. I totally agree with Carolina's comment, it seems very difficult for users to get the entire Page Template to change when Replacing a Header or Footer Page Template Part, even though it it was one would think is happening. |
This has been solved with #35827, closing. |
Description
Using header template parts as an example:
Picture that a block theme has two header template part files that are both registered to use the header template part area.
When the default header template part is selected in the site editor, it has a toolbar option called replace. When you select replace, you can switch the template part for another.
This replacement prompts saving the first template part.
But it does not prompt saving the change to the current template. This means that on the front, the first, presumably replaced, template part still shows.
Refreshing the site editor also reverts back to displaying the first template part.
(With default template part, I mean the part who's slug is used in the markup of the template .html file in the theme.)
Did I misunderstand the purpose of the replace feature?
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
WordPress 5.8.1, Gutenberg Version 11.6.0, and trunk
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: