Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOOKS: Naming is unexpected #3620

Closed
2 tasks
tg-ephox opened this issue Nov 23, 2017 · 3 comments · Fixed by #3621
Closed
2 tasks

HOOKS: Naming is unexpected #3620

tg-ephox opened this issue Nov 23, 2017 · 3 comments · Fixed by #3621
Assignees

Comments

@tg-ephox
Copy link
Contributor

Issue Overview

Existing hooks use naming like 'core\anchor-attribute' but the '\a' is a non-existent escape sequence so this is interpreted as 'coreanchor-attribute'.

I stumbled across this today investigating hooks for use in footnotes and created a hook named 'core\footontes' but '\f' is a valid escape sequence for ASCII character 12 (Line Feed) so my hook name was failing validation here

Incidently the coment here wasn't updated when the validation rules changed.

Possible Solution

Use '-' to delimit hook name.

Screenshots / Video

screen shot 2017-11-23 at 3 49 40 pm

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@gziolo
Copy link
Member

gziolo commented Nov 23, 2017

@aduth pinging you so you were aware why \a got replaced with - for the hook namespace.

@aduth
Copy link
Member

aduth commented Nov 24, 2017

I think a better permanent solution is to update the underlying hooks implementation to use / for namespacing.

@gziolo
Copy link
Member

gziolo commented Nov 24, 2017

Agreed, we need to relax validation first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants