Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Sub menu icon doesn't scale with menu font size #36923

Closed
neilorangepeel opened this issue Nov 26, 2021 · 4 comments · Fixed by #36948
Closed

Navigation Block: Sub menu icon doesn't scale with menu font size #36923

neilorangepeel opened this issue Nov 26, 2021 · 4 comments · Fixed by #36948
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@neilorangepeel
Copy link

Description

The sub menu icon/chevron doesn't reflect the font size of the menu. If the menu has a large type size applied the icon remains the same.

Potential solution

Add inherit font size to the parent button

.wp-block-navigation__submenu-icon { font-size: inherit; }

Step-by-step reproduction instructions

  1. Within the editor add navigation block
  2. Add submenu to navigation
  3. Edit the font size of the navigation e.g. 30px
  4. Submenu icon will be different from the main font size

Screenshots, screen recording, code snippet

Sub menu chevron isn't the same size as the type.
Screenshot 2021-11-26 at 22 05 04

Sub menu chevron matching the font size of the menu.
Screenshot 2021-11-26 at 22 03 29

Environment info

Wordpress Version 5.9-alpha-52250
Gutenberg Version 12.1.20211126

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Nov 28, 2021
@mtias
Copy link
Member

mtias commented Nov 29, 2021

Are you testing with trunk? This was addressed in #36714.

@mtias mtias added [Status] Needs More Info Follow-up required in order to be actionable. and removed [Type] Bug An existing feature does not function as intended labels Nov 29, 2021
@neilorangepeel
Copy link
Author

Are you testing with trunk? This was addressed in #36714.

Yes. I should have mentioned the issue seems to be just the front-end as on the front-end the icon is contained in a <button> element and seems to be inheriting user-agent-styles.

Screenshot 2021-11-29 at 10 34 22

@mtias
Copy link
Member

mtias commented Nov 29, 2021

Ah, thanks for the clarification!

@mtias mtias added [Type] Bug An existing feature does not function as intended and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Nov 29, 2021
@jasmussen jasmussen mentioned this issue Nov 29, 2021
7 tasks
@jasmussen
Copy link
Contributor

Apologies! I somehow failed to test the frontend in my previous fix. Thanks for the suggestion, PR here: #36948.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants