Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced Patterns: Focus name text field when opening new reusable block modal #37240

Open
Rolilink opened this issue Dec 8, 2021 · 2 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.

Comments

@Rolilink
Copy link

Rolilink commented Dec 8, 2021

What problem does this address?

Users need to click the name text field to input the name of the reusable block, this feels odd since is the only input in the modal.

What is your proposed solution?

I think we should autofocus the input when the modal is opened.

This issue was reported on the wp-calypso repo by a user in this issue.

@jordesign
Copy link
Contributor

Just noting this is still relevant when creating Patterns (instead of reusable blocks)

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 18, 2023
@jordesign jordesign changed the title [Reusable Block]: Focus name text field when opening new reusable block modal Synced Patterns: Focus name text field when opening new reusable block modal Oct 30, 2023
@joedolson
Copy link
Contributor

From an accessibility standpoint, consistency is probably the most important characteristic. We discussed this in accessibility bug scrub today, and while the modal no longer has only one input field, we noted that the Rename dialog autofocuses the input. Since these two controls are accessed from the same context and are very similar, it makes sense to us for them to behave the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants