Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proper loading state to the Archives block #37552

Closed
jameskoster opened this issue Dec 21, 2021 · 0 comments · Fixed by #37623
Closed

Add a proper loading state to the Archives block #37552

jameskoster opened this issue Dec 21, 2021 · 0 comments · Fixed by #37623
Assignees
@Mamaduka
Labels
[Block] Archives Affects the Archives Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The Archives block / widget doesn't seem to have a proper loading state. Instead I see a "Block rendered as empty" message before the archives actually appear:

archives.mp4

We can probably use a similar loading state as other blocks like embeds.
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Block] Archives Affects the Archives Block labels Dec 21, 2021
@Mamaduka Mamaduka mentioned this issue Dec 24, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Archives Affects the Archives Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ServerSideRender: Fix loading state WordPress/gutenberg
2 participants
@Mamaduka @jameskoster