Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late escape RSS block #37878

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Late escape RSS block #37878

merged 3 commits into from
Jan 12, 2022

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 11, 2022

Description

This is not a security problem. This PR simply moves escaping of all PHP output to be as "late" as possible. This means we avoid escaping variables until they are output in the HTML markup.

This is a WP Core best practice.

How has this been tested?

  • add both blocks
  • check functionality is "as was"
  • check all tests pass

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed [Type] Security Related to security concerns or efforts labels Jan 11, 2022
@getdave getdave self-assigned this Jan 11, 2022
@getdave getdave requested a review from Mamaduka January 12, 2022 11:43
Mamaduka
Mamaduka approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dave. Changes look good to me.

@getdave getdave merged commit 43ab543 into trunk Jan 12, 2022
@getdave getdave deleted the update/late-escape-rss-block branch January 12, 2022 12:34
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 12, 2022
@fullofcaffeine fullofcaffeine mentioned this pull request Jan 20, 2022
Merged
fullofcaffeine added a commit that referenced this pull request Jan 20, 2022
@fullofcaffeine
Revert "Late escape RSS block (#37878)"
7581a0e 
This reverts commit 43ab543.
noahtallen pushed a commit that referenced this pull request Jan 20, 2022
@fullofcaffeine
Revert "Late escape RSS block (#37878)" (#38117)
019ad7f 
This reverts commit 43ab543.
noahtallen pushed a commit that referenced this pull request Jan 21, 2022
@fullofcaffeine @noahtallen
Revert "Late escape RSS block (#37878)" (#38117)
046ceb2 
This reverts commit 43ab543.
@getdave getdave mentioned this pull request Feb 7, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras left review comments

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@getdave getdave

Labels
[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed [Type] Code Quality Issues or PRs that relate to code quality [Type] Security Related to security concerns or efforts
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@getdave @Mamaduka @ntsekouras