Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Color Picker] Make custom HEX text field available without a click #37981

Closed
kjellr opened this issue Jan 14, 2022 · 6 comments
Closed

[Color Picker] Make custom HEX text field available without a click #37981

kjellr opened this issue Jan 14, 2022 · 6 comments
Assignees
Labels
[Feature] Colors Color management Needs Design Feedback Needs general design feedback.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 14, 2022

Currently (Gutenberg 12.4), the color value inputs are not available unless you click on the "Show detailed inputs" button. If you don't click that button, click on the hex value shown, you'll activate a "Copy" action.

inputs

Users who want to input their own custom HEX values need to learn to hit that icon before they can modify the current HEX value. I've found this to be confusing personally — more often than not, I'm coming here to input a custom value, not copy one, and I have to do an extra click to make that happen. Besides, the copy action feels a little over-engineered: it's generally common to copy/paste content from a standard form field.

I'd suggest we just go ahead and show the detailed inputs by default:

Screen Shot 2022-01-14 at 8 31 26 AM

... and if we really want a copy action, we can display it where the "Show detailed inputs" button currently lives:

Group 657

(We'd need a new icon though, I just borrowed the "Pages" icon for now)

@kjellr kjellr added Needs Design Feedback Needs general design feedback. [Feature] Colors Color management labels Jan 14, 2022
@jasmussen
Copy link
Contributor

This makes sense to me. Designwise, one thing we could do is keep the interface as is, only let the hex code be editable on click, and then surface a copy icon inside the input field when it's focused?

@supernovia
Copy link

then surface a copy icon inside the input field when it's focused?

I like that. Can we be sure the copy format matches what one should paste, or better, make the input field automatically handle hex code whether or not there's a # in front?

@dozentis
Copy link

dozentis commented Feb 24, 2022

Nice, that you mentioned this issue, I am also annoyed by this and wanted to report. (I had to recolor 10 blocks lately, and when inserting the hex value, I kept accidentally coming up with copy instead of edit

Four clicks and a long way with the mouse to paste a color value from clipboard. (screenshot WP5.9.1)

colorpicking1
)

@dozentis
Copy link

dozentis commented Feb 24, 2022

My suggestion for quicker copying the color-value

copy-color

@dozentis
Copy link

dozentis commented Feb 24, 2022

And there is a little bug when copying a color by click from there and paste to another place. If you paste a copied color you'll notice that it pastes the hex sign too and the color becomes invalid.

colorpicker-paste-bug

@aaronrobertshaw
Copy link
Contributor

The two main issues here should now be resolved with #41222 and #41223 landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

5 participants