Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight text: Format button doesn't match current color when moving the caret #38246

Closed
fluiddot opened this issue Jan 26, 2022 · 4 comments · Fixed by #57650
Closed

Highlight text: Format button doesn't match current color when moving the caret #38246

fluiddot opened this issue Jan 26, 2022 · 4 comments · Fixed by #57650
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects

Comments

@fluiddot
Copy link
Contributor

Description

While testing the Highlight text feature, especially the changes introduced in #37915, I noticed that the format button doesn't reflect the current color when placing the caret at the end of the text (see attached video capture).

Step-by-step reproduction instructions

  1. Add a Paragraph block.
  2. Type some text.
  3. Tap on the Highlight text format button and select a color.
  4. Type some more text and observe that the selected color is applied to the text written.
  5. Move the caret around and place it at the end of the text.
  6. Type some more text.
  7. Observe that the text written has previously selected color but the Highlight text format button shows no color.

Expected behaviour

After moving the caret, the Highlight text format button should reflect the same color as the one applied to the text.

Actual behaviour

After moving the caret, the Highlight text format doesn't reflect the same color as the one applied to the text.

Screenshots or screen recording (optional)

ios-highlight-text-color.MP4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 11
  • Operating system: iOS 15.1
  • WordPress app version: 19.1
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 26, 2022
@geriux geriux self-assigned this Jan 26, 2022
@hypest hypest added this to Triage in Mobile Apps via automation Feb 4, 2022
@hypest hypest moved this from Triage to To do in Mobile Apps Feb 4, 2022
@mchowning
Copy link
Contributor

mchowning commented Feb 8, 2022

In addition, it seems that the behavior is quite a bit worse when swiping words on iOS. The swiping, as opposed to typing--of the words seemed to be important in recreating the issue. I'm not sure what original priority was assigned to this issue, but the behavior when swiping on iOS seems pretty poor to me and feels like it would justify making this a higher priority.

Not Resetting Color

For example,

  1. Create a new paragraph block
  2. Apply a highlight color
  3. Swipe a word (observe that the highlight color is applied)
  4. "Reset" the highlight color (or change to a different color)
  5. Swipe a second word (observe that the original highlight color persists).
remove_color.mov

Resetting Color on "Earlier" Words

Now this is a fun one. With some persistence, I can get the color of "earlier" words to sometimes "update". It seems to happen more often when iOS autocorrects a word. 😮

change-earlier.mov

@geriux
Copy link
Member

geriux commented Feb 9, 2022

Thanks for the report!

but the behavior when swiping on iOS seems pretty poor to me and feels like it would justify making this a higher priority.

Yeah, I think we should look into this and try to tackle the pending bugs related to this feature including the swiping words one.

@mchowning mchowning added the [Priority] High Used to indicate top priority items that need quick attention label Feb 9, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 15, 2022
@geriux geriux added Mobile App - Automation Label used to initiate Mobile App PR Automation and removed Mobile App - Automation Label used to initiate Mobile App PR Automation labels Mar 16, 2022
@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 5, 2024

I confirmed this is still reproducible in version 23.9. I'd keep the [Priority] High` label as it affects the writing flow.

@geriux I saw that you were working on a fix on Aztec (reference) some time ago. I'm wondering if we could resume the work, let me know if I can help anyhow. Otherwise, feel free to unassign from the issue.

@geriux
Copy link
Member

geriux commented Jan 8, 2024

@geriux I saw that you were working on a fix on Aztec (wordpress-mobile/AztecEditor-iOS#1352 (comment)) some time ago. I'm wondering if we could resume the work, let me know if I can help anyhow. Otherwise, feel free to unassign from the issue.

I'm going to pick this up this week, so we can move forward with that fix.

@geriux geriux removed the [Priority] High Used to indicate top priority items that need quick attention label Jan 12, 2024
Mobile Apps automation moved this from To do to Done Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Mobile Apps
  
Done
3 participants