Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Login/out block in the Navigation block #38512

Closed
getdave opened this issue Feb 4, 2022 · 4 comments · Fixed by #49160
Closed

Enable Login/out block in the Navigation block #38512

getdave opened this issue Feb 4, 2022 · 4 comments · Fixed by #49160
Assignees
@getdave
Labels
[Block] Login/out Affects the Login/out Block [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Feb 4, 2022

What problem does this address?

In #37717 we learnt the Nav block doesn't support the login/out block.

What is your proposed solution?

Add the block to the allowed blocks of the Nav block.
@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Login/out Affects the Login/out Block labels Feb 4, 2022
@getdave getdave mentioned this issue Feb 4, 2022
Open
38 tasks
@mrfoxtalbot mrfoxtalbot added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Jul 21, 2022
@mrfoxtalbot
Copy link

While not exactly a duplicate, this is rather similar to #31636
Would it make sense to close either of the two @getdave?

@mrfoxtalbot mrfoxtalbot added the [Type] Enhancement A suggestion for improvement. label Jul 21, 2022
@getdave
Copy link
Contributor Author

getdave commented Jul 21, 2022

@mrfoxtalbot I think this one is specifically relating to allowing the existing Login block within the Nav block. The other one appears distinct in that it is about creating a Register/Log in/Log out Button block.

@getdave getdave mentioned this issue Mar 17, 2023
Merged
2 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 17, 2023
@ideadude ideadude mentioned this issue Apr 26, 2023
Closed
@annpocoyo
Copy link

Is this issue still active. I came across this today and this was the exact problem I had.

@mrfoxtalbot
Copy link

Hey @annpocoyo, this feature is being add and should be available soon.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Block] Login/out Affects the Login/out Block [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Loginout block in Nav block WordPress/gutenberg
4 participants
@getdave @mrfoxtalbot @priethor @annpocoyo