Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Query Loop: Simplify and clarify the block settings #38864

Closed
DAreRodz opened this issue Feb 16, 2022 · 1 comment
Closed

Comments Query Loop: Simplify and clarify the block settings #38864

DAreRodz opened this issue Feb 16, 2022 · 1 comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.

Comments

@DAreRodz
Copy link
Contributor

What problem does this address?

This issue was arisen in #38187 (comment).

There are some concerns regarding the current settings of the Comment Query Loop block. Naming is confusing, e.g., “Order by” only affects the order in which the comments are listed in a page, not the pages order.

In addition, for the same setting, there is no exact correlation between the values in Gutenberg and the values in the dashboard, e.g., “Default page” lets you choose between “Oldest” or “Newest”, but it’s not clear what page is going to be shown (are “Oldest” or “Newest” the “first” or the last “page” you can select in the WP Discussion Settings?).

These are the current settings of the Comment Query Loop block (in Gutenberg):

image

These are the Discussion settings that match the Comment Query Loop settings (in the dashboard):

Screenshot 2022-02-16 at 18 14 42

What is your proposed solution?

Let's continue the conversation here. This is a summary of what was mentioned so far:

  • We could make settings more specific so it's clearer what they do, e.g. divide “Order by” into “Order pages by” and “Order items on the page by” (mentioned by @gziolo).

  • Another option would be to merge the “Order by” and the “Default page” options in a single toggle: “Show newest comments first”, in order to make things simpler at this stage (mentioned by @jasmussen).

  • In regard to adding some helping texts for users, we could add some help-text below the “Inherit from Discussion Settings” toggle, something like: Use globally defined sort order and comment settings. You can configure these in [link]Discussion Settings[/link] (mentioned by @jasmussen).

  • Or maybe add some text on the global Discussion settings to clarify that the ordering and default page options are defaults, and might be overwritten by the theme/template (mentioned by @jameskoster).


cc @SantosGuillamot @c4rl0sbr4v0 @michalczaplinski

@DAreRodz DAreRodz added [Type] Enhancement A suggestion for improvement. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Feb 16, 2022
@DAreRodz DAreRodz added this to To do in Comments Loop block via automation Feb 16, 2022
@SantosGuillamot SantosGuillamot moved this from To do to Backlog in Comments Loop block Apr 18, 2022
@DAreRodz
Copy link
Contributor Author

DAreRodz commented Nov 9, 2022

I think we can close this issue as this is not relevant anymore. To add some context, we decided a while ago to remove the settings from this block and inherit them from the WP settings. See #39648 and #39664.

@DAreRodz DAreRodz closed this as completed Nov 9, 2022
Comments Loop block automation moved this from Backlog to Done Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

No branches or pull requests

1 participant