Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: disable dragging if a block is locked #40072

Closed
annezazu opened this issue Apr 6, 2022 · 4 comments · Fixed by #40086
Closed

List View: disable dragging if a block is locked #40072

annezazu opened this issue Apr 6, 2022 · 4 comments · Fixed by #40086
Assignees
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2022

What problem does this address?

Currently, if a block is locked, you can still begin to drag and drop it in List View. The dropping doesn't actually occur but this experience feels confusing since it allows you to begin the process:

drag.and.drop.lock.mov

This came up during the 6.0 walk through.

What is your proposed solution?

Disable dragging and drop in list view when block is locked. cc @andrewserong once more!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Block Locking The API allowing for the ability to lock/unlock blocks labels Apr 6, 2022
@andrewserong
Copy link
Contributor

andrewserong commented Apr 6, 2022

Good catch! I wonder if there should be a locked icon potentially in the list view, too? (Might need some design feedback, if so). Also CC: @Mamaduka has been doing a bunch of work with the locking behaviour, too 🙂

@annezazu
Copy link
Contributor Author

annezazu commented Apr 6, 2022

I wonder if there should be a locked icon potentially in the list view, too?

Opening too many issues and forgot to cross link ;) #40070

@Mamaduka
Copy link
Member

Mamaduka commented Apr 6, 2022

Thanks for creating the issue, @annezazu.

This is on my to-do list, so going to assign it to myself :)

@Mamaduka Mamaduka self-assigned this Apr 6, 2022
@andrewserong
Copy link
Contributor

Opening too many issues and forgot to cross link ;)

Ah, perfect. Thanks, I missed that one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants