Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Comment Template -> Columns -> change parent and inner blocks text colors #40257

Closed
paaljoachim opened this issue Apr 12, 2022 · 2 comments
Labels
[Block] Comment Template Affects the Comment Template Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 12, 2022

Description

  1. Comment Template -> Columns. Change the text color to white.
  2. Click Comment Date/Comment Author. Change the text color to green.

Which should decide the color of the Comment Date/Comment Author?
Parent or the inner block itself?

Step-by-step reproduction instructions

See above.

Screenshots, screen recording, code snippet

Backend Columns selected.
Notice Color:
Text is white
Background has a gradient.
Screenshot 2022-04-12 at 10 03 19

Selecting Comment Author.
Notice Color:
Text changed to orange.
Screenshot 2022-04-12 at 10 05 22

Frontend (no change to Comment Author color is seen)

Screenshot 2022-04-12 at 10 06 22

Environment info

WP 5.9.3
Gutenberg plugin 13.0RC2
Twenty Twenty Two

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

Associated issue:
[Block] Comment Template -> Columns - change text colors does not affect Edit and Reply text
#40255

@paaljoachim paaljoachim added [Type] Bug An existing feature does not function as intended [Block] Comment Template Affects the Comment Template Block Needs Testing Needs further testing to be confirmed. labels Apr 12, 2022
@carolinan
Copy link
Contributor

carolinan commented Apr 25, 2022

The inner block setting should always be applied, if it is set. If it is not set, then it should use the parent block setting.

The comment author should only be colored by the text color setting if the option "link to authors URL" is toggled off. When it is on, which is the default, it is colored by the link color setting.

@paaljoachim
Copy link
Contributor Author

Resting.
WP version 6.0.1
Gutenberg plugin: 13.7.2
Twenty Twenty Two

Going to Editor. Home template.
Just above the Footer. I added a Comments block.
Clicked Comment Content (Comments > Comment Template > Columns > Column > Comment Content)
and changed the color to red: Link.

Clicked Comment Author ( Comments > Comment Template > Columns > Column > Comment Author Name)
and changed the color to red: Link.

It looks good here so I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Template Affects the Comment Template Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants