Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles welcome guide's button styling is not consistent #41226

Closed
juhi123 opened this issue May 23, 2022 · 1 comment
Closed

Styles welcome guide's button styling is not consistent #41226

juhi123 opened this issue May 23, 2022 · 1 comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback.

Comments

@juhi123
Copy link
Contributor

juhi123 commented May 23, 2022

Description

I couldn't understand the logic behind having different styling for Previous and Get Started button than Next button, I believe buttons should have the same styling,
The next button has color 1386bf and font is bold, raised a PR to fix that

Step-by-step reproduction instructions

  1. Go to Site Editor
  2. Click on Styles
  3. In the sidebar panel, click on Welcome Guide

Screenshots, screen recording, code snippet

previous-getstarted-button

next-button

Environment info

  • WordPress 6.0 RC 4
  • macOS Monterey

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@juhi123 juhi123 mentioned this issue May 23, 2022
Closed
@justintadlock justintadlock added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels May 24, 2022
@jordesign
Copy link
Contributor

This is no longer reproducible in WP6.3 - I'm seeing different button style now.

Screenshot 2023-09-05 at 2 45 09 pm

To my mind this is a deliberate stylistic/focus difference so I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justintadlock @jordesign @juhi123