Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template editing: List existing template parts in the Inserter Patterns tab #41399

Open
Tracked by #41241
jameskoster opened this issue May 27, 2022 · 3 comments
Open
Tracked by #41241
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

What problem does this address?

The Patterns inserter surfaces header and footer patterns that may have already been used to create template parts at the site. Consequently it's very easy to insert a pattern in a template where an existing template part might be preferable.

What is your proposed solution?

If we list existing template parts in the pattern inserter we can hopefully reduce the likelihood of such occurrences. We'd need to ensure the UI clearly distinguishes patterns / template parts.

A couple of ideas to kick off discussions:

Screenshot 2022-05-27 at 12 14 37

@jameskoster jameskoster added [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels May 27, 2022
@jameskoster jameskoster added the [Block] Template Part Affects the Template Parts Block label Jun 24, 2022
@jameskoster
Copy link
Contributor Author

For option C to work in the quick inserter we'd need to add the category dropdown there too. It could work, but in general I find scrolling and/or searching to be easier versus operating a dropdown. There's also a slightly awkward overlap... we'd have a "Template Parts" category, and a "Footers" category... it might be too confusing.

@ntsekouras
Copy link
Contributor

@jameskoster do you think this issue is still relevant, given the inserter has been updated since the creation of it?

@jameskoster
Copy link
Contributor Author

Yes I think so, particularly as concepts like Template Parts, Patterns, Reusable blocks continue to converge.

It would be nice to find template parts here, ideally with ones that are in active use being visually marked somehow:

Screenshot 2023-06-14 at 13 07 31

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants