Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge a template update in a theme with your customised version of that same template #41764

Open
jameskoster opened this issue Jun 16, 2022 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Consider the following flow:

  • Activate AwesomeTheme 1.0.
  • Customise the Page template in the Site Editor.
  • Update to AwesomeTheme 2.0, which includes changes to the Page template.

It would be nice if there was a way to pull the updates made to the bundled template into your customised version.

When the blocks remain the same (just ordering / attributes changed) it would hopefully be possible perform such a merge automatically. Here there are similarities with pattern transforms which we've explored before. It may be nice to have a before / after preview to confirm, perhaps with options that allow you to choose what to pull in; attributes, composition, meta, everything.

It's not entirely clear to me how far we can go with this approach, but my assumption is that there will be a point where automatic merging simply isn't possible. In these cases we might not surface the merge option in the UI at all, or alternatively offer some kind of 'conflict resolution' UI.


As a side note, theme switches might be a consideration here. Should it be possible to merge a customised version of a template supplied by Theme A with one supplied by Theme B?

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 16, 2022
@SaxonF
Copy link
Contributor

SaxonF commented Jun 29, 2022

Could this behave in a similar way to reverting synced blocks/patters back to their library/global state?

@jameskoster
Copy link
Contributor Author

jameskoster commented Jun 29, 2022

I think this is slightly different as it is about pulling in updates rather than resetting. The 'clear customisations' action we have for templates / template parts can probably be considered for synced blocks though, once we have established a source of truth for those in the UI, and implemented overrides :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants