Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate schema file for Style Variations #42823

Open
johnstonphilip opened this issue Jul 29, 2022 · 2 comments
Open

Separate schema file for Style Variations #42823

johnstonphilip opened this issue Jul 29, 2022 · 2 comments
Labels
[Feature] Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.

Comments

@johnstonphilip
Copy link
Contributor

What problem does this address?

A separate schema file might be needed for style variations. There are already several differences:

What is your proposed solution?

A separate, dedicated schema file should be created if style variations are going to have different supported fields and values.

@johnstonphilip johnstonphilip added the [Feature] Style Variations Related to style variations provided by block themes label Jul 29, 2022
@johnstonphilip

This comment was marked as resolved.

@Mamaduka
Copy link
Member

Mamaduka commented Aug 1, 2022

@johnstonphilip, the theme in this case is the origin of the settings and doesn't need to be defined in theme.json. Instead, these are used for specifications and how styles are merged.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants