Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme.json: dynamic references, avoid recursive references #43154

Closed
MaggieCabrera opened this issue Aug 11, 2022 · 1 comment · Fixed by #43166
Closed

Theme.json: dynamic references, avoid recursive references #43154

MaggieCabrera opened this issue Aug 11, 2022 · 1 comment · Fixed by #43166
Assignees

Comments

@MaggieCabrera
Copy link
Contributor

Description

Pointed out in #42976, the editor crashes when there's a recursive reference in place.

Step-by-step reproduction instructions

In theme.json add:

"color": {
    "background": { "ref": "styles.color.text" },
    "text": {"ref": "styles.color.background" }
},

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ramonjd
Copy link
Member

ramonjd commented Aug 12, 2022

I have a fix for this. Just writing some tests and will push a PR soon.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 12, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants