Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display homepage settings in the front-page Template Inspector #43418

Closed
jameskoster opened this issue Aug 19, 2022 · 5 comments
Closed

Display homepage settings in the front-page Template Inspector #43418

jameskoster opened this issue Aug 19, 2022 · 5 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The front-page template is unique in that it will always display the homepage regardless of what the homepage is set to display in the reading settings.

Therefore we might consider pulling the homepage display settings directly into the Inspector panel for this template. Here's a rough example of how this could work:

front-page.mp4

I think this could potentially elevate the perception of this template, which is otherwise a bit confusing.

Related: #42554

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 19, 2022
@jameskoster jameskoster changed the title Consider displaying homepage settings in the front-page Template Inspector Display homepage settings in the front-page Template Inspector Sep 21, 2022
@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Sep 21, 2022
@jffng
Copy link
Contributor

jffng commented Nov 9, 2022

directly into the Inspector panel for this template

Do you think it makes sense to surface these settings just for front-page? I think there are other cases or templates where it could be useful to surface the reading settings in the site editor.

@jameskoster
Copy link
Contributor Author

It's a bit tricky. We might surface posts-per-page settings in the Archive template, but since that setting can affect other templates it might be confusing?

That's the nice thing about homepage settings and the front-page template – it's totally self-contained. When front-page exists it will always display the homepage.

Did you have anything specific in mind?

@jffng
Copy link
Contributor

jffng commented Nov 10, 2022

I was thinking that it could make sense to display these settings for index, or home since depending on what templates are provided, these settings could have an impact. But I see what you mean, I don't think it would make sense to display these settings in those templates since they are not always relevant.

What's still tricky about adding these settings to front-page — would it require by convention a query block to exist in the template for the expected result?

@jameskoster
Copy link
Contributor Author

Yes good point, a Query (that inherits from the template) is mandatory for the settings to have any effect.

I suppose another option could be to surface these settings on the Query block itself, but only when situated in the front-page template, and only when it inherits. That sound a bit finicky though.

@annezazu
Copy link
Contributor

I'm going to close this out in favor of #49597 as that has more context and momentum right now while still covering the same issue at hand.

Feel free to reopen if I'm missing something though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants