Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Browse styles" in the global style sidebar does not always show #43554

Open
carolinan opened this issue Aug 24, 2022 · 2 comments
Open

"Browse styles" in the global style sidebar does not always show #43554

carolinan opened this issue Aug 24, 2022 · 2 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

When a theme has theme.json style variations:
Normally I have to wait 15 seconds before the "browse styles" option is visible in the global styles sidebar. This feels too long.
But sometimes, it does not show up at all, and I have to refresh the site editor and wait again.

Tested in different themes, including Twenty Twenty-Three.

Step-by-step reproduction instructions

I am not sure how to reproduce this consistently. I am using:
Mac
Chrome version 104.0.5112.101
Local by flywheel nginx, PHP 8.0.0, mySQL 8.0.16.
WordPress 6.0.1.
Gutenberg current trunk, no other plugins
Twenty Twenty-Three

A "classic" menu from the theme test data is used in the themes header navigation block.

  1. Activate the theme
  2. Open the Site editor
  3. Open the global styles sidebar
  4. Wait...

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Aug 30, 2022
@talldan
Copy link
Contributor

talldan commented Aug 30, 2022

I haven't been able to reproduce the issue with it not appearing, but it doesn't seem ideal that it loads in asynchronously. It's probably also not great for accessibility, because there's a chance that a user may tab past it, not realising the button isn't present yet in the UI.

If it can't be loaded synchronously it should probably at least have a loading indicator and be focusable.

@colorful-tones
Copy link
Member

I have noticed the lag in loading, and it is certainly long enough that it warrants attention. However, I have not experienced it not loading altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants