Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline toolbar keyboard navigation should be consistent with block toolbar #43564

Closed
tellthemachines opened this issue Aug 24, 2022 · 0 comments · Fixed by #43645
Closed

Inline toolbar keyboard navigation should be consistent with block toolbar #43564

tellthemachines opened this issue Aug 24, 2022 · 0 comments · Fixed by #43645
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

Description

Currently, the block toolbar, once focused, is navigable with the Arrow keys, because it uses the NavigableToolbar component.

But the inline toolbar, such as appears for Image block captions, doesn't use the same component, so it can only be navigated with Tab key. Ideally, keyboard behaviour should be consistent across both toolbars. We could use NavigableToolbar for the inline toolbar too.

Step-by-step reproduction instructions

  1. Add an Image block to the page, and insert an image in it;
  2. Caption should be focused automatically;
  3. Press Shift+Tab to enter the caption toolbar;
  4. Note that the toolbar buttons can only be reached by using Tab or Shift+Tab.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Aug 24, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 26, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants