Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spacing in exploded padding control #44121

Closed
jameskoster opened this issue Sep 13, 2022 · 1 comment · Fixed by #44141
Closed

Update spacing in exploded padding control #44121

jameskoster opened this issue Sep 13, 2022 · 1 comment · Fixed by #44141
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system

Comments

@jameskoster
Copy link
Contributor

Part of #43412

The current spacing is poor because the range is equidistant from the label before and after, which can make it hard to understand which control and which label are related:

Screenshot 2022-09-13 at 13 06 02

It would be good to update the spacing so that there's a larger gap between the control and the subsequent label.

Screenshot 2022-09-13 at 13 06 39

Considering #41973 it would also be good to increase the height of the input itself to 40px instead of the current 30px.

@glendaviesnz
Copy link
Contributor

@jameskoster I have a PR for this here. It was hard to get the exact dimensions you specified due to the way the range control is absolute positioned, but let me know what you think and let me know if you think it needs further px adjustments.

I also added a slight indent when in unlinked mode which I think really helps to indicate which dimension setting the controls relate to, particularly if you have margin and padding settings.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system
Projects
None yet
3 participants