Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to margin / padding visualizer #44700

Closed
mtias opened this issue Oct 5, 2022 · 13 comments
Closed

Tweaks to margin / padding visualizer #44700

mtias opened this issue Oct 5, 2022 · 13 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Oct 5, 2022

It'd be nice if hovering or focusing on the margin / padding / gap tools would display the overlays even if you are not dragging the value handles. cc @talldan .

It also seems like we should try to not render the toolbar while showing the overlays (at least margin). It should feel a bit more like engaging "is typing" to avoid the toolbar rendering through:

before

@mtias mtias added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Oct 5, 2022
@glendaviesnz glendaviesnz self-assigned this Oct 6, 2022
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Oct 13, 2022

@mtias did you have any thoughts on whether the visualiser should appear for the duration of the time that you are moused over the control, or just appear briefly as it does now when adjusting sizes?

@mtias
Copy link
Member Author

mtias commented Oct 13, 2022

Not quite sure, would need to get a feel for it.

@glendaviesnz
Copy link
Contributor

it seems a little odd just having a brief view of the visualiser when mousing over to match the same temporary view when adjusting:

mouseover-brief.mp4

seems to work better to keep the visualiser in place the whole time moused over the control:

hover-permanent.mp4

@glendaviesnz
Copy link
Contributor

A PoC PR here for the mouseover part of this.

@talldan
Copy link
Contributor

talldan commented Oct 14, 2022

seems to work better to keep the visualiser in place the whole time moused over the control

Agree, that works really well. 👍

@mtias
Copy link
Member Author

mtias commented Oct 14, 2022

Indeed, let's keep it visible during the whole interaction.

@talldan
Copy link
Contributor

talldan commented Nov 25, 2022

I think this is mostly done now, though perhaps one thing that's missing is that the visualizer doesn't show on focus of the padding or margin controls.

@glendaviesnz
Copy link
Contributor

@talldan have added focus here

@talldan
Copy link
Contributor

talldan commented Dec 5, 2022

That's great! Nice work, I'll close this issue as completed 🎉

@talldan talldan closed this as completed Dec 5, 2022
@mtias
Copy link
Member Author

mtias commented Dec 5, 2022

One thing to keep in mind — I mentioned in another PR that it'd be good to explore a more systematic approach to interactions that should / could hide the toolbar like "is typing" does. Direct manipulations of inspector control tools come to mind in general, but also canvas resizing.

@glendaviesnz
Copy link
Contributor

One thing to keep in mind — I mentioned in another PR that it'd be good to explore a more systematic approach to interactions that should / could hide the toolbar like "is typing" does. Direct manipulations of inspector control tools come to mind in general, but also canvas resizing.

@mtias there is some more work being done around this here

@mtias
Copy link
Member Author

mtias commented Dec 7, 2022

Is #46192 the best issue to track the work?

@glendaviesnz
Copy link
Contributor

Is #46192 the best issue to track the work?

I think so, and have now updated the title to better reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants