Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style variations are not being saved if the sidebar isn't on the variations screen #45165

Closed
mmtr opened this issue Oct 20, 2022 · 3 comments
Closed
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@mmtr
Copy link
Contributor

mmtr commented Oct 20, 2022

Description

Originally reported by @dsas in Automattic/wp-calypso#68707 but moved it here after realizing this is a Gutenberg issue.

When changing to a non-default style variation, the choice is not saved when clicking save if the variation screen is navigated away from.

Step-by-step reproduction instructions

  • Make sure you're using the latest version of Gutenberg (14.3.1), since the issue is not reproducible in older versions (e.g. 14.0.2)
  • Activate a block theme such as Twenty Twenty-Two
  • Open the site editor (wp-admin/site-editor.php)
  • Click Browse styles
  • Choose a non-default variation, i.e. any variation except the top left one
  • Notice the preview in the main part of the screen changes to match the selected variation
  • Click the '<' next to 'Browse styles' to go back in the sidebar
  • Press Save
  • Observe how the sidebar very quickly (it's just a flash) changes to the Browse styles page and then changes back.
  • Observe how the Save button is not disabled
  • Visit the frontend and observe how the original variation is still being used.

Screenshots, screen recording, code snippet

Screen.Recording.2022-10-20.at.16.42.32.mov

Environment info

  • WordPress: 6.0.3
  • Gutenberg: 14.3.1
  • Theme: Twenty Twenty-Two

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mmtr mmtr added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Oct 20, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Nov 4, 2022

Hi, @mmtr

I followed the reproduction steps and could not reproduce the issue using WP 6.1 with and without Gutenberg 14.5 RC. Tested using 2022 and 2023 themes.

Can you confirm that you are still seeing the bug?

@mmtr
Copy link
Contributor Author

mmtr commented Nov 4, 2022

You're right @Mamaduka. Seems the issue was solved in Gutenberg 14.4.0 since I cannot reproduce it on that version (but it's still present in 14.3.1).

@mmtr mmtr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Nov 4, 2022

Thanks for the update, @mmtr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants