Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insertion indicator is not showing when hovering on patterns #45183

Closed
kevin940726 opened this issue Oct 21, 2022 · 0 comments · Fixed by #47316
Closed

Insertion indicator is not showing when hovering on patterns #45183

kevin940726 opened this issue Oct 21, 2022 · 0 comments · Fixed by #47316
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

Description

Hovering on the block options in the global inserter will show a blue line indicator in the editor to indicate where the block will be inserted at. However, the same indicator is not showing when hovering on the patterns options in the global inserter.

E2E tests are added in #44631 (comment).

Step-by-step reproduction instructions

  1. Go to the post editor
  2. Add some dummy content in the editor
  3. Open the global inserter
  4. Switch to the "patterns" tab
  5. Hover on one of the pattern, expect the blue line indicator to show somewhere in the editor

Screenshots, screen recording, code snippet

Kapture.2022-10-21.at.10.43.52.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Oct 21, 2022
@kevin940726 kevin940726 mentioned this issue Oct 21, 2022
Merged
@t-hamano t-hamano mentioned this issue Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pattern Inserter: show insertion indicator when hovering on patterns WordPress/gutenberg
1 participant
@kevin940726