Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP code should not throw any WordPress.NamingConventions.PrefixAllGlobals type linter errors #45817

Closed
anton-vlasenko opened this issue Nov 16, 2022 · 1 comment
Closed

PHP code should not throw any WordPress.NamingConventions.PrefixAllGlobals type linter errors #45817

anton-vlasenko opened this issue Nov 16, 2022 · 1 comment
Assignees
@anton-vlasenko
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Nov 16, 2022 •
edited
Loading

What problem does this address?

There is an effort to make Gutenberg compatible with extended WordPress code style standards - WordPress-Extra, thus easing the backporting process.

Currently, Gutenberg's PHP code is not up to these strict standards.
This issue is created to fix code style errors that prevent enabling the WordPress.NamingConventions.PrefixAllGlobals linter rule.
Please see this issue to get additional context.
Additionally, you can find the specifics of WordPress coding standards here - https://developer.wordpress.org/coding-standards/wordpress-coding-standards.

What is your proposed solution?

There are false positives and "actual" linter errors.
The "real" errors that violate WordPress.NamingConventions.PrefixAllGlobals family of rules should be fixed.
@anton-vlasenko anton-vlasenko added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 16, 2022
@anton-vlasenko anton-vlasenko self-assigned this Nov 16, 2022
@anton-vlasenko anton-vlasenko mentioned this issue Nov 16, 2022
Closed
@anton-vlasenko anton-vlasenko changed the title Gutenberg's PHP code should not throw any WordPress.NamingConventions.PrefixAllGlobals type linter errors PHP code should not throw any WordPress.NamingConventions.PrefixAllGlobals type linter errors Nov 16, 2022
@anton-vlasenko anton-vlasenko added the [Type] Enhancement A suggestion for improvement. label Nov 16, 2022
@bph bph removed the [Type] Enhancement A suggestion for improvement. label Nov 16, 2022
This was referenced Nov 23, 2022
Open
Open
@anton-vlasenko
Copy link
Contributor Author

#44884 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anton-vlasenko anton-vlasenko

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix WordPress.NamingConventions.PrefixAllGlobals type linter errors WordPress/gutenberg
2 participants
@bph @anton-vlasenko