Multiple revisions created on save

[tnprescott]

Description

I'm not sure if this is related to issue #16006, but whenever I try to save an update to page content and an update to a custom field at the same time, it creates two revisions. The first revision shows the page content being changed and all the custom post meta values being removed and the second revision shows all the values being repopulated. It does this for new and published paegs. We're currently on WordPress 5.9.3 and ACF Pro version 5.11.4.

Step-by-step reproduction instructions

1. Using ACF Pro v5.11.4, create a field group and add a custom field "Header Image Scale" to it. Make it a select box with values of
   noZoom : No Zoom
   one_twentyFive : 1.25x
   one_fifty : 1.5x
   one_seventyFive : 1.75x
   two : 2x
   Make noZoom the default value.
2. Create a new page and edit the page content as well as change the Header Image Scale to 1.5x.
3. Save the page and check the revisions. There should be two revisions for the one save where the first one strips out the custom post meta and the second adds it back in.

Screenshots, screen recording, code snippet

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes, No

[ndiego]

Hi @tnprescott, this issue was reviewed during the Editor Bug Scrub. We have been able to replicate the situation and it is likely due to the fact that WordPress saves meta boxes separately from post content. Other than making reverting to prior revisions tricky, is this causing any other issues for you?

[tnprescott]

Hi @ndiego, it's not creating any other major issues as of right now, just not an ideal situation. Do you know of any kind of work around or is it just something to deal with until a fix can be created?

[Mamaduka]

I believe this is due to the ACF plugin overriding the editor.savePost to enable revisions for post meta. I cannot reproduce this when testing with a custom post-meta plugin.

Sorry for the ping, @lgladdy, but can you confirm this behavior?

As mentioned in #16006, WP won't create a revision by default when only the post meta is changed.

P.S. There's renewed effort to enable revisions for post-meta. See https://core.trac.wordpress.org/ticket/20564.