Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop block: Split settings awkwardness with "Create a new post for this feed" prompt #46472

Closed
annezazu opened this issue Dec 12, 2022 · 2 comments · Fixed by #46147
Closed
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Description

When using the split settings #40204 options under Gutenberg > Experiments, if you add a Query Loop block, the settings tab runs into some awkward layouts with the "Create a new post for this feed" prompt. cc @aaronrobertshaw @gutenberg

Step-by-step reproduction instructions

  1. Enable split settings under Gutenberg > Experiments.
  2. Open the site editor.
  3. Add a query loop block.
  4. Go to the "settings" tab and notice awkwardness in spacing.

Screenshots, screen recording, code snippet

Screen Shot 2022-12-12 at 10 21 12 AM

Environment info

  • WP 6.1.1
  • GB 14.7
  • TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Query Loop Affects the Query Loop Block labels Dec 12, 2022
@aaronrobertshaw
Copy link
Contributor

Thanks for writing up this issue @annezazu 👍

I've explored a couple of approaches to addressing this already. The first ( #45437 ) was the addition of a new slot above the sidebar tabs so we could move the link. This PR was abandoned primarily due to concerns around blocks potentially abusing it to push their controls to more prominent positions than they merit.

The second approach ( #46147 ), that should be landing soon, is to remove the color controls from the Query block so that it will be a "settings only" block. The result will be that the Query block doesn't show tabs and the create new post link will appear in its usual position.

@annezazu
Copy link
Contributor Author

Fantastic! Thank you for the context and for already doing work to resolve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants