Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Offcanvas inserter/appender button should provide more context #47011

Closed
getdave opened this issue Jan 10, 2023 · 0 comments · Fixed by #47033
Closed

Nav Offcanvas inserter/appender button should provide more context #47011

getdave opened this issue Jan 10, 2023 · 0 comments · Fixed by #47033
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

As reported in #46939 (comment) the accessible name Add block isn't a descriptive enough label for the Inserter without more context.

This should change to Add block to Navigation menu which would be preferable.

Also @talldan mentioned:

As Alex mention it would be good if the appender had some indication of context, blocks in List View have an aria-description like this - "Block 2 of 3, Level 1", which help give screenreader users an idea of order and nesting level, some extra information along these lines might be good. There might also be more that can be done, like announcing what the parent block is and that this appends to the end.

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block [a11y] Labelling labels Jan 10, 2023
@getdave getdave changed the title Nav Offcanvas inserter button should provide more context Nav Offcanvas inserter/appender button should provide more context Jan 10, 2023
@getdave getdave self-assigned this Jan 10, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 10, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants