Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: global Save button shows up when not needed #47882

Closed
afercia opened this issue Feb 8, 2023 · 0 comments · Fixed by #47895
Closed

Site Editor: global Save button shows up when not needed #47882

afercia opened this issue Feb 8, 2023 · 0 comments · Fixed by #47895
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 8, 2023

Description

It appears the 'global' Save button added to the Site editor sidebar in #47142 shows up unexpectedly in some flows where it's not actually needed.

In the 'browse mode' templates list, users can take some actions. For example they can:

  • Rename a custom template.
  • Clear customizations made to a template.

When taking these actions, the 'Save' button appears in the 'saving' state at the bottom of the sidebar. Screenshot:

Screenshot 2023-02-08 at 14 18 41

For better clarity, here's an animated GIF:

save-button-sidebar

The global Save button makes perfectly sense for the scenarios illustrated in #47142 and #46985

I'm not sure it should show up at all when saving changes from the templates list. That's totally unexpected and confusing for users. I'm guessing this potentially happens for all the flows where there's a similar saving process.

Cc @youknowriad

Step-by-step reproduction instructions

  • Go to the Site Editor.
  • Create a custom template.
  • Switch back to 'browse' more and click Templates > Manage all templates.
  • From the templates list, click the 'Actions' button related to the custom template you created.
  • Choose 'Rename', set a new name for the template and save.
  • Observe that while saving, the global 'Save' button unexpectedly shows up in the Sidebar and the button is in the 'saving' state.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 8, 2023
@glendaviesnz glendaviesnz self-assigned this Feb 9, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 9, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
3 participants