-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block copy/paste: Paste missing a snackbar & should it replace or append? #49255
Comments
I don't think we need a paste snackbar—if you can see a result of pasting, though the "copied" snackbar is helpful as there is no other indicator of success. But it looks like in the recording, you're technically copying the block—but pasting the block's styling. Copy/pasting blocks and styles are essentially the same action, just dependent on if you're selected on another block or not. Here's the same flow, but showing the styles being applied: CleanShot.2023-03-22.at.15.26.06.mp4But we do have a snackbar that indicates the result of copying/pasting styles, when you use the "Copy styles" and "Paste styles" controls (which I also don't think is necessary; there is already a visual indication of styles pasted). CleanShot.2023-03-22.at.15.30.33.mp4We should consider making "Copy/Paste" aways append (not have the dual function as copying/pasting styles) and maintain a copied snackbar. And perhaps use that same logic for the Copy/Paste of styling (copied snackbar). |
I appreciate your attention to detail and a non-intrusive flow, but in the two videos you shared, it actually wasn't clear enough to me visually that a paste operation was succesful.
That seems a good starting point, as it would accomodate a clear visual paste operation. But in absence of this, I'd add a paste snackbar. |
The pasting I demonstrated was pasting of the styles (the color/font sizes) — not appending a new block. :) |
Oh sure, and although that has some visual effect if the copied block has styles, if it doesn't, you won't know it worked. It's not a strong opinion, but I think snackbars are kinda perfect for this, my main frustration here is that the snackbars linger for so long. |
Ah, I'm following now. :)
Yes. |
Pasting styles actually have a totally different flow though, and the original gif is not that flow. Seems like pasting a block on another block always replaces the original block. The exception is when the user focuses on a rich-text element rather than selecting the whole block. In that case, pasting a block triggers That said, the question in the title is still valid though, and we can discuss more in this issue :). |
When I select a block and press ⌘C, the block gets copied, highlighted by a snackbar.
There's no snackbar when I paste, making it unclear that it actually worked, because the paste action replaces the block.
Shown in this GIF, successfully copying a post title block. Not visible in the GIF is me pressing ⌘V repeatedly to paste. If you see the list view, the ellipsis blinks, indicating that the block actually does get replaced. But without a snackbar confirming this, it isn't obvious:
Outside of the snackbar, I wonder: should the block-level paste action always replace, or should it append? My expectation from other design apps is that it should append. This is different from a partial text selection, where I would expect it to replace.
The text was updated successfully, but these errors were encountered: