Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time To Read Block - Translations are ignored #49694

Closed
masteradhoc opened this issue Apr 10, 2023 · 3 comments · Fixed by #49704
Closed

Time To Read Block - Translations are ignored #49694

masteradhoc opened this issue Apr 10, 2023 · 3 comments · Fixed by #49704
Labels
[Block] Time to Read Affects the Time to Read Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@masteradhoc
Copy link
Contributor

masteradhoc commented Apr 10, 2023

Description

Thanks @t-hamano for the great Time to Read Block. Im trying to integrate it and found one small issue in regards to translations
Although my user and also my site is in german im still getting the english translations although it seems they are translated correctly here: https://translate.wordpress.org/projects/wp-plugins/gutenberg/stable/de/default/?filters%5Bterm%5D=minut&filters%5Bterm_scope%5D=scope_any&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

Step-by-step reproduction instructions

  1. Create a Page
  2. Add the Time to Read Block
  3. visit the frontend and check if it shows in your set language (other than english!)
  4. check if strings are translated in the translation files (f.e. german here)
    https://translate.wordpress.org/projects/wp-plugins/gutenberg/stable/de/default/?filters%5Bterm%5D=minut&filters%5Bterm_scope%5D=scope_any&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

Screenshots, screen recording, code snippet

See the difference between the translated date (month) and the not translated "minutes" of the Time to Read Block.
image

Environment info

  • newest WordPress
  • newest Gutenberg Version
  • Edge Browser

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added the [Block] Time to Read Affects the Time to Read Block label Apr 10, 2023
@kathrynwp
Copy link

I was able to replicate this in another language:

  • WP 6.2
  • Gutenberg 15.5.0
  • Language set to Español (ES) - translations

One interesting thing I noticed is that the word "minutes" did correctly display in Spanish in the Editor, even though the front end still displayed English.

Editor

Editar_la_página___Testing_Testing_123_—_WordPress

Front End

Testing_Testing_123

@masteradhoc
Copy link
Contributor Author

@kathrynwp good note, same here. 👍🏻

@kathrynwp kathrynwp added the [Type] Bug An existing feature does not function as intended label Apr 10, 2023
@t-hamano
Copy link
Contributor

Thanks for the PR.

This issue should be fixed in #49704, but I can't explain why yet, I would like to investigate 😅

@t-hamano t-hamano added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Time to Read Affects the Time to Read Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants