Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern & Media List Items: Improve metrics to account for chevrons #50753

Closed
richtabor opened this issue May 18, 2023 · 3 comments · Fixed by #55598
Closed

Pattern & Media List Items: Improve metrics to account for chevrons #50753

richtabor opened this issue May 18, 2023 · 3 comments · Fixed by #55598
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented May 18, 2023

While technically correct, we can make small adjustments to the menu item components within list items to make these appear more visually balanced.

Current

Notice the varying visual space to the left and right of the list item, visible on both resting and active states (red blocks are different sizes on each side:

current

Proposed

By changing the padding-right value to 4px, the resting and active states of the list items are visually balanced (red blocks are the same size on each side):

proposed
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. labels May 18, 2023
@jasmussen
Copy link
Contributor

Sounds good to me. Might be good to sync up with the very similar componentry employed for the site view that @jameskoster and @SaxonF have explored (i.e. the hover state for navigator drilldowns).

@jameskoster
Copy link
Contributor

The menu items Joen refers to have unequal horizontal padding to account for the chevron, so it seems reasonable to do the same thing here.

If we're concerned with consistency, we might also consider using the small chevron variant.

@richtabor
Copy link
Member Author

If we're concerned with consistency, we might also consider using the small chevron variant.

Yea, I brought that up here as a candidate: #50754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants