Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substract the height of a sticky group if a cover block's height is 100% #51015

Open
JosVelasco opened this issue May 26, 2023 · 2 comments
Open
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.

Comments

@JosVelasco
Copy link

What problem does this address?

If a block uses the toggle to activate the full height and there is a sticky group, usually the header for navigation, the content is not 100% visible.

What is your proposed solution?

Add an option to consider the height of a sticky group so the content of a block with 100% height can be seen without having to scroll.

@Thelmachido
Copy link

Hi @JosVelasco are you able to provide more information about this issue, possibly:

  • The environment you are working in i.e. Name of the theme you are using, WP version, and plugins activated.
  • Providing a screenshot or screencast of what you are seeing on your end?

@Thelmachido Thelmachido added [Package] Block editor /packages/block-editor [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels May 31, 2023
@JosVelasco
Copy link
Author

To make the header sticky, convert it to a group and select Sticky under the Position option.

I use Twenty Twenty-Three Version: 1.1 and WordPress 6.2.2 with no plugins.

I tried with and without Gutenberg Version 15.9.0.

I inserted a cover block with full height and a header group block with much padding for demonstration purposes.

full.cover.sticky.mp4

@mrfoxtalbot mrfoxtalbot added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants