Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between Guide component closing via Finish button or Close button #51244

Open
nathanss opened this issue Jun 5, 2023 · 0 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@nathanss
Copy link

nathanss commented Jun 5, 2023

What problem does this address?

I'm using the Guide component to show a 4 step guide on this PR.

button.focusing.mov

We would like to fire different events depending if the user closes the dialog through the Close button or the last step's finish button.

What is your proposed solution?

Either provide two different callbacks (onClose and onFinish) or provide a parameter on the onFinish callback to allow the component's consumer to know what was the button clicked.

@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants