Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal navigation: getting trapped in site editor outside the navigation #51291

Closed
simison opened this issue Jun 7, 2023 · 3 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@simison
Copy link
Member

simison commented Jun 7, 2023

Description

When I open the full browser window navigation modal in Lettre theme using site editor, and then click outside the modal, I cannot get back to edit it easily.

Step-by-step reproduction instructions

  • Using Lettre theme
  • In site editor
  • Click yourself into header template, and navigation hamburger icon, and open the navigation modal.
  • All is fine, you can edit the navigation styles
  • Click outside the navigation. I think you end up selecting something outside the header, but I'm not sure.
  • The navigation modal stays open.
  • I cannot enter navigation modal by clicking the editor canvas anymore
  • I can enter navigation modal via List view

Maybe ther problem is that navigation modal isn't closing, yet editing context is switched to something else? Or that I cannot enter back to header just by clicking it again? Result feels buggy.

Screenshots, screen recording, code snippet

Screen.Recording.2023-06-07.at.14.32.19.mov

Environment info

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@simison simison added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 7, 2023
@aurooba
Copy link
Member

aurooba commented Jun 7, 2023

@simison Thanks for adding this report! When you open the menu modal in the site editor, the way to close it is by clicking the X close icon. I've attached a screenshot where I'm doing it in the Twenty Twenty Three theme.

Screen.Recording.2023-06-07.at.9.39.50.AM.mov

I did also test the Lettre theme you mentioned and it looks like the styling in that theme makes the close icon hard to select in the header, although with a few tries, I did manage it. This is definitely something you should take up with the theme author. I hope that helps!

I'm closing this issue because it doesn't seem to be a problem with Core or Gutenberg, but rather is affected by the theme styling. But if you find that the issue is replicable in other themes/plugins and is related to Core or Gutenberg, this issue can be reopened!

@scruffian
Copy link
Contributor

I think the problem here is that the blocks behind the navigation overlay can be selected. I proposed a fix in #51378.

@scruffian
Copy link
Contributor

Closed by #51378 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants