Query Pagination: Remove unwanted bottom margins from links

[iamtakashi]

Description

It's minor, but I remove it in every theme I work on. The bottom margins 0.5em on the block's links seem unnecessary, creating misalignment. Can we remove them?

Step-by-step reproduction instructions

1. Go to Editor
2. Add a query pagination block
3. See the bottom margin added to the elements in the block.

Screenshots, screen recording, code snippet

No response

Environment info

• WP 6.2.2
• Gutenberg trunk
• Chrome, Mac

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[aurooba]

Good note, @iamtakashi! I believe the margin is there to deal with the scenario where those different elements are get really close to one another. Perhaps instead of an arbitrary 0.5em, we could take advantage of the blockGap property instead? 🤔

[iamtakashi]

@aurooba Thanks for sharing your thought.

Whatever comes after the pagination block already has the top margin equivalent to the blockGap. But because of the unwanted bottom margin, the gap is bigger than how it should be. (Notice the gap between the orange(top margin on the image block) and the link in the pagination block.)

It feels safe to remove the bottom margin though I wonder if anyone knows the intention.

[aurooba]

Ah yes, I see what you're saying. For some reason I thought that the blockGap wasn't set to apply on the inner pagination blocks, but upon looking at it again, I can see that it is. I agree with you, the bottom margin can likely be removed from the inner pagination blocks.

Since blockGap didn't always exist, it's possible that the this margin was added before and then just got missed when blockGap was introduced.

For those folks who have blockGap disabled, do you think it would be a reasonable assumption that there would be no margin at all or in those cases should this margin still exist?

[iamtakashi]

Since blockGap didn't always exist, it's possible that the this margin was added before and then just got missed when blockGap was introduced.

That's what I guess too.

For those folks who have blockGap disabled, do you think it would be a reasonable assumption that there would be no margin at all or in those cases should this margin still exist?

That's a good question. Unlike a p or figure elements, it doesn't have margins from the user agent stylesheet, and it could bump to other blocks in some cases when the blockGap is disabled.

If Global Styles allows controlling the margins for the block, it'd be easier to remove it. Would that be a better solution?