Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern block: Rename "Convert to regular block" #51940

Closed
richtabor opened this issue Jun 26, 2023 · 8 comments · Fixed by #51993
Closed

Pattern block: Rename "Convert to regular block" #51940

richtabor opened this issue Jun 26, 2023 · 8 comments · Fixed by #51993
Assignees
Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Jun 26, 2023

Consider renaming the "Convert to regular block" control to "Unsync", or an alternative.

If we don't have a good icon for unsyncing, the text label would be fine enough I think.

CleanShot 2023-06-26 at 16 25 47
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. labels Jun 26, 2023
@richtabor
Copy link
Member Author

An aside; I don't think we need two of the same controls so close together. Can probably remove this one within the options menu.

CleanShot 2023-06-26 at 17 01 05

@carlomanf
Copy link

"Unsync" is not a real word and I don't think it belongs here or in any part of the interface, not least because it would cause difficulty for translators. What about "Stop synchronising" instead?

@richtabor
Copy link
Member Author

What about "Stop synchronising" instead?

That’s much less ideal + not intuitive.

With the introduction of pattern creation and syncing, blocks aren’t “regular” or not. So we need to come to some solution here.

@richtabor
Copy link
Member Author

Other alternative is to use “Detach”, much like Figma components.

@richtabor richtabor changed the title Pattern block: Rename "Convert to regular block" to "Unsync" Pattern block: Rename "Convert to regular block" Jun 27, 2023
@jasmussen
Copy link
Contributor

Was just about to suggest "Detach block".

@richtabor
Copy link
Member Author

Was just about to suggest "Detach block".

What about "Detach pattern"?

@jasmussen
Copy link
Contributor

Right, yes, the patterns are not always grouped 👍 👍

@carolinan
Copy link
Contributor

In template parts, the text is "Detach blocks from template part," and it is only in the drop-down. Shouldn't these match?

Screenshot 2023-06-28 at 05 39 13

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants