Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: Add some context about the currently selected category to the main 'Library Content' region #52006

Closed
talldan opened this issue Jun 28, 2023 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jun 28, 2023

Description

In the library, a user selects a category using the options in the 'navigation' region.
Screen Shot 2023-06-28 at 11 44 52 am

In the main 'Library content' region there's no contextual clues as to what category is currently being viewed.
Screen Shot 2023-06-28 at 11 46 01 am

This would likely be frustrating for anyone using a screenreader, as the only way to know the selected category would be to check back through the navigation items to find the one currently selected.

To improve this, I think it'd be good to add a heading at the start of the main area. If it doesn't fit with the design it could be VisuallyHidden.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Tab to the Library option in the Navigation region and select it
  3. Tab through the available categories that appear and select one
  4. Use the 'navigate regions' shortcut to move to the 'Library Content' region
  5. Search through the content in that region and observe there's no indication of the selected category.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended [a11y] Labelling [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jun 28, 2023
@joedolson
Copy link
Contributor

I think this would be a good improvement; having some context clues about what kind of content you're currently working with at a high and granular level is very valuable.

I'll note that there is a heading in place - 'Synced/Standard' is an H4. This is an invalid heading sequence; given the context, it should be an H2.

I don't see any heading that indicates the context being Patterns, let alone categories of patterns; all of that would be useful.

For any given category, there should be a heading at level H2 to give context. With that, the current H4 should move to H3 so that the hierarchy is consistent.

I'd prefer a visible heading, particularly on mobile, where the sidebar isn't visible while working in the library.

@jameskoster
Copy link
Contributor

I think recent updates to the pattern library mean this can be closed. Sections all now have a contextual title and the majority also have a description. Some examples:

Screenshot 2023-07-10 at 21 39 02 Screenshot 2023-07-10 at 21 39 20 Screenshot 2023-07-10 at 21 39 32

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
Development

No branches or pull requests

4 participants