Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show synced patterns (reusable blocks) in the Patterns tab of the main inserter #52224

Closed
t-hamano opened this issue Jul 2, 2023 · 2 comments
Closed

Show synced patterns (reusable blocks) in the Patterns tab of the main inserter #52224

t-hamano opened this issue Jul 2, 2023 · 2 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jul 2, 2023

I got the idea from this core ticket: https://core.trac.wordpress.org/ticket/58697

What problem does this address?

Patterns appear in My Patterns on the Library page of the Site Editor, with or without synced status.

library

However, in the main block inserter, it is treated as a Synced Pattern (conventional Reusable Blocks), separate from the pattern tab.

synced-patterns

What is your proposed solution?

I would expect that the synced patterns tab would be discontinued and that the synced patterns would also be displayed in "My Patterns" in the Patterns tab.

In this case, I think the state of synchronization needs to be represented in some way.
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 2, 2023
@t-hamano t-hamano changed the title I got the idea from this core ticket Show synced patterns (reusable blocks) in the Patterns tab of the main inserter Jul 2, 2023
@eric7186
Copy link

eric7186 commented Jul 3, 2023

Bug Report

Description

Describe the bug.

Environment

  • WordPress: 6.3-beta2
  • PHP: 8.1.9
  • Server: Apache/2.4.43 (Win32) mod_fcgid/2.3.9a
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.9)
  • Browser: Chrome 114.0.0.0 (Windows 10/11)
  • Theme: Twenty Twenty-Three 1.1
  • MU-Plugins: None activated
  • Plugins:
    • WordPress Beta Tester 3.5.0

Steps to Reproduce

  1. Create a pattern with the option selected: Keep all pattern instances in sync.
  2. The Pattern shows as a synced pattern here
  3. 🐞 Synced pattern tab does not show up in the block inserter. I also checked firefox and edge browsers. It did work earlier in firefox but not today

Expected Results

  1. ✅ What should happen.

Actual Results

  1. ❌ What actually happened.

@annezazu
Copy link
Contributor

annezazu commented Jul 3, 2023

This seems to be a duplicate of #51945. Closing out as a result.

@annezazu annezazu closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eric7186 @annezazu @t-hamano