Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should theme.json support RTL and vertical writing? #52353

Open
miminari opened this issue Jul 6, 2023 · 1 comment
Open

How should theme.json support RTL and vertical writing? #52353

miminari opened this issue Jul 6, 2023 · 1 comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@miminari
Copy link
Member

miminari commented Jul 6, 2023

What problem does this address?

I am looking at this ticket and wondering if RTL support is needed for theme.json.
https://core.trac.wordpress.org/ticket/57506

Considering the vertical writing feature, I feel that the concept of the logical property ( https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values ) should also be introduced in theme.json.

What is your proposed solution?

This is not concrete at all, but I'll try to write it down.

  1. for example, add something like "RTL mode" in theme.json?
  2. Abd add logical properties settings for borders, margins, padding, etc.

Finally, as a Japanese, I would be very happy if I could write Japanese vertical text in WordPress, and for that, I need to be able to have styles for vertical writing. For example, there are styles specific to vertical writing, such as bullet points, emphasis lines on the right side, etc. To be consistent with these styles, I think we maybe need the concept of logical properties in theme.json at first, and isn't this also relevant to other language environments such as RTL?

I don't think this is enough, but I would like to start thinking about this with you guys anyway.
Thank you.

maybe related: #50319 #52299

@carolinan carolinan added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Jul 6, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants
@miminari @jordesign @carolinan and others