Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part renaming modal doesn't not decode entities #52419

Closed
getdave opened this issue Jul 7, 2023 · 1 comment · Fixed by #52449
Closed

Template Part renaming modal doesn't not decode entities #52419

getdave opened this issue Jul 7, 2023 · 1 comment · Fixed by #52449
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jul 7, 2023

Create a custom Template Part containing some HTML entity such as David's Template Part (note the apostophe).

Now go to the TP listing page and click Rename. See that the title shows the encoded title: David’s Custom TP.

Needs decodeEntities.
Screen Shot 2023-07-07 at 12 39 00

This also happens on the listing page:

Screen Shot 2023-07-07 at 12 45 06
@getdave getdave added [Block] Template Part Affects the Template Parts Block [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Type] Bug An existing feature does not function as intended labels Jul 7, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Jul 9, 2023

I have confirmed that this problem also occurs with custom template renaming modal.

template

On the other hand, it does not occur with the navigation renaming modal.

navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Type] Bug An existing feature does not function as intended
Projects
2 participants