Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Navigation block render function to be open for extension #52470

Closed
getdave opened this issue Jul 10, 2023 · 2 comments
Closed

Refactor Navigation block render function to be open for extension #52470

getdave opened this issue Jul 10, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Jul 10, 2023

Over the years the render_block_core_navigation function has grown to be pretty unwiedly. Making any changes is prone to error and there's little in the way of direct test coverage (we do have e2e tests).

Let's start an incremental refactor with lots of small PRs which break this function down into discreet functions which do one thing. As this process occurs let's add PHPUnit tests to provide test coverage for the smaller functions.

When complete the main render_block_core_navigation should be easy to reason about and extend.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Jul 10, 2023
@getdave
Copy link
Contributor Author

getdave commented Nov 21, 2023

@scruffian Can we close this out?

@scruffian
Copy link
Contributor

Yes! This was fixed by #55605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

2 participants